So, Lord Erebus also has the same minion summoning with less life issue that Sedna, Oak, and the Queen of Thorns has. However, because his units summon in the middle of combat and typically have access to life regeneration, this has not been noticed. This has further been complicated because when Lord Erebus possesses the conversion aura, his units are given full health when created. The combination of these three things has lead to the incorrect belief that Lord Erebus does not suffer from the changes done to fix item manipulation and minion health levels. However, to counter this, most Lord Erebus builds include Conversion at an early level, so in effect Lord Erebus only infrequently creates minions with low health.
To demonstrate the effect of items on Lord Erebus Minions:
Start a skirmish game with Lord Erebus.
Buy the level 1 minotaur idol and move away from the healing crystal before summoning. Note that the minotaurs are summoned with full health.
Buy God Plate and suicide your minotaurs.
Move away from the healing crystal and resummon the minotaurs, note that they no longer are summoned with max health.
Next, proceed to a creep wave and remain in range until a vampire is created. Note that its health is not maxed. Repeat until you are convinced the health level is stable, less than max at creation. Suicide minions are necessary to allow new vampires to be created.
Now, purchase the conversion aura rank 1. Proceed to create new vampire minions by killing creeps. Note that now your vampires are spawned with full health.
A good demonstration of the effect of the change due to abuse of dropping and equipping items is:
Start a skirmish game with any general and buy God Plate. Summon a minion, and then repeatedly drop and reequip the God Plate. Your minion’s current health will eventually drop to 1.
When Lord Erebus has the Conversion Aura, a check is performed that results in his units being healed to full, specifically in:
\Demigod\bindata\units\heroes\HVampire\HVampire_Abilities.lua
lines: 833-841
The line that heals the spawned vampires is:
839: vampireling:AdjustHealth(vampireling:GetMaxHealth())
Although healing is incorrect, this line sets the health of the vampire to max health.
So, how to fix the problem? It is simple enough.
First off, in the Hvampire_Abilities.lua file, move line 839 down two lines, outside of the validation check for Conversion and for Coven. This will ensure that Lord Erebus’s vampires are always reset to full health after being spawned.
Next, do similar sorts of adjustments to the other generals, Sedna, Queen of Thorns, and if you really have to Oak (he is overpowered anyway).
(It’s a joke btw, so relax).
An example of how this would be done for the Queen of Thorns. Open:
\Demigod\bindata\units\heroes\HVampire\HQueen_Abilities.lua
Go to line 205, right before
CountShamblers(def.MaxShamblers, shambler)
Add:
shambler:AdjustHealth(shambler:GetMaxHealth())
Now, when she summons Shamblers they will be healed.
To fix the general idols, you’d have to edit the
\lua\common\Items\Generals_Items.lua
and add a similar line to the generic summoning code, something like
minion:AdjustHealth(minion:GetMaxHealth()) around line 40 would most likely work.
So, unless I missed something, this should fix all the minion health glitches.
Also, I can confirm that the Ptarth guy above's changes fix the problem with the Sigil. Plus he is really handsome.
